fix WOOVerzoeken typo #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deze PR fixt een typo in de API specs en ItemController. Op dit moment zijn we geforceerd om WooVerzoeken verkeerd te spellen in onze API specs, omdat de ItemController specifiek naar "Wooverzoeken" op zoek is.
Wanneer we "Wooverzoeken" gebruiken in onze API specs in plaats van camelcase "WooVerzoeken" dan krijg je een WOOItemList model met verkeerde namen:
Op dit moment lossen we dit zelf op met een patch, maar het is netter om dit in de plugin al te fixen voor toekomstige gemeentes.
Let op, als je dit aanpast is het wel een breaking change in de plugin.
Groetjes,
Ken
Level Level